Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercased ECS launch types #1339

Merged
merged 9 commits into from
Jan 27, 2021

Conversation

willarmiros
Copy link
Contributor

@willarmiros willarmiros commented Jan 14, 2021

Changes

  • Lower case options for launch type in Amazon ECS spec for consistency with other lowercased values

@willarmiros
Copy link
Contributor Author

Looks like the semantic-conventions check is failing for an unrelated reason. Verified locally that make table-generation doesn't update anything.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an entry in the changelog about this?

@bogdandrutu
Copy link
Member

Can you please add an entry in the changelog about this?

For @willarmiros :)

@willarmiros willarmiros requested review from a team as code owners January 26, 2021 19:42
@willarmiros
Copy link
Contributor Author

@bogdandrutu done :)

Not sure why I'm getting failures on semantic-conventions again :/

@Oberon00
Copy link
Member

The output says:
File /spec/metrics/semantic_conventions/rpc.md contains a table that would be reformatted.

@willarmiros
Copy link
Contributor Author

@Oberon00 Right, and I'm confused because I didn't touch rpc.yaml or rpc.md in my change, and the check runs just fine on my local branch:

$ docker run --rm -v $(pwd)/semantic_conventions:/source -v $(pwd)/specification:/spec otel/semconvgen -f /source markdown -md /spec --md-check
58 files left unchanged.

@Oberon00
Copy link
Member

@thisthat Do you have an idea what could be the problem?

@thisthat
Copy link
Member

thisthat commented Jan 27, 2021

@thisthat Do you have an idea what could be the problem?

It looks like the wrong version is used. There was a new release a few hours ago.
@willarmiros I suggest deleting the local image and let it download again from docker hub. You can do that by running docker image rm otel/semconvgen

Now that we have a release with a proper version, we should pin the semantic tool to tag 0.2.1.

EDIT: I've created #1381

@willarmiros
Copy link
Contributor Author

@thisthat you're right that was it, thanks! Looks like a lot of markdown just got updated with whitespace and other auto-generated changes.

@bogdandrutu bogdandrutu merged commit 11cc739 into open-telemetry:master Jan 27, 2021
@willarmiros willarmiros deleted the lowercase-type branch January 27, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants