Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlang process.runtime attributes: remove TODO note and update descriptions #1445

Merged
merged 3 commits into from
Feb 19, 2021
Merged

erlang process.runtime attributes: remove TODO note and update descriptions #1445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb18de1
erlang process.runtime attributes: remove TODO note and update descri…
tsloughter Feb 17, 2021
1eb74cd
erlang: update spec matrix
tsloughter Feb 17, 2021
72ada66
add erlang runtime example
tsloughter Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions spec-compliance-matrix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ status of the feature is not known.
| Safe for concurrent calls | | + | + | + | + | + | + | + | + | + | + | + |
| Shutdown (SDK only required) | | | + | + | + | + | - | | + | + | + | + |
| [Trace / Context interaction](specification/trace/api.md#context-interaction) | | | | | | | | | | | | |
| Get active Span | | | + | + | + | + | N/A | | + | + | + | + |
| Set active Span | | | + | + | + | + | N/A | | + | + | + | + |
| Get active Span | | | + | + | + | + | + | | + | + | + | + |
| Set active Span | | | + | + | + | + | + | | + | + | + | + |
| [Tracer](specification/trace/api.md#tracer-operations) | | | | | | | | | | | | |
| Create a new Span | | + | + | + | + | + | + | + | + | + | + | + |
| Get active Span | | + | + | + | + | + | + | + | + | + | + | + |
Expand Down Expand Up @@ -68,7 +68,7 @@ status of the feature is not known.
| [Sampling](specification/trace/sdk.md#sampling) | | | | | | | | | | | | |
| Allow samplers to modify tracestate | | | + | | + | + | + | | + | | - | + |
| ShouldSample gets full parent Context | | | + | + | + | + | + | | | + | - | + |
| [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | | | | + | + | | | | | - | + |
| [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | | | | + | + | + | | | | - | + |
| [IdGenerators](specification/trace/sdk.md#id-generators) | | | | | | + | | | | | | |
| [SpanLimits](specification/trace/sdk.md#span-limits) | X | | | | | + | | | | | | |

Expand All @@ -91,9 +91,9 @@ status of the feature is not known.
|---------------------------------------------------------------------------------------------------------------------------------------------|----------|----|------|----|--------|------|--------|-----|------|-----|------|-------|
| Create from Attributes | | + | + | + | + | + | + | | + | + | + | + |
| Create empty | | + | + | + | + | + | + | | + | + | + | + |
| [Merge (v2)](specification/resource/sdk.md#merge) | | | | | + | + | | | | + | + | |
| [Merge (v2)](specification/resource/sdk.md#merge) | | | | | + | + | + | | | + | + | |
| Retrieve attributes | | + | + | + | + | + | + | | + | + | + | + |
| [Default value](specification/resource/semantic_conventions/README.md#semantic-attributes-with-sdk-provided-default-value) for service.name | | | | | + | + | | | | + | + | |
| [Default value](specification/resource/semantic_conventions/README.md#semantic-attributes-with-sdk-provided-default-value) for service.name | | | | | + | + | + | | | + | + | |

## Context Propagation

Expand Down Expand Up @@ -122,20 +122,20 @@ Note: Support for environment variables is optional.

|Feature |Go |Java|JS |Python|Ruby|Erlang|PHP|Rust|C++|.Net|Swift|
|----------------------------------------------|---|----|---|------|----|------|---|----|---|----|-----|
|OTEL_RESOURCE_ATTRIBUTES | + | + | + | + | + | - | - | + | - | + | - |
|OTEL_LOG_LEVEL | | - | + | [-](https://github.com/open-telemetry/opentelemetry-python/issues/1059) | + | - | - | | - | - | - | |
|OTEL_PROPAGATORS | | + | | + | + | - | - | | - | - | - |
|OTEL_BSP_* | | + | | + | + | - | - | + | - | - | - |
|OTEL_RESOURCE_ATTRIBUTES | + | + | + | + | + | + | - | + | - | + | - |
|OTEL_LOG_LEVEL | | - | + | [-](https://github.com/open-telemetry/opentelemetry-python/issues/1059) | + | + | - | | - | - | - | |
|OTEL_PROPAGATORS | | + | | + | + | + | - | | - | - | - |
|OTEL_BSP_* | | + | | + | + | + | - | + | - | - | - |
|OTEL_EXPORTER_OTLP_* | | - | | - | + | - | - | | - | - | - |
|OTEL_EXPORTER_JAEGER_* | | + | | + | + | - | - | + | - | - | - |
|OTEL_EXPORTER_ZIPKIN_* | | + | | + | | - | - | | - | - | - |
|OTEL_TRACES_EXPORTER | | | | + | + | | | | | | |
|OTEL_METRICS_EXPORTER | | + | | + | | | | | | - | - |
|OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | | | | + | + | | | | | | |
|OTEL_SPAN_EVENT_COUNT_LIMIT | | | | + | + | | | | | | |
|OTEL_SPAN_LINK_COUNT_LIMIT | | | | + | + | | | | | | |
|OTEL_TRACES_SAMPLER | | | | + | + | | | | | | |
|OTEL_TRACES_SAMPLER_ARG | | | | + | + | | | | | | |
|OTEL_TRACES_EXPORTER | | | | + | + | + | | | | | |
|OTEL_METRICS_EXPORTER | | + | | + | | - | | | | - | - |
|OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | | | | + | + | - | | | | | |
|OTEL_SPAN_EVENT_COUNT_LIMIT | | | | + | + | - | | | | | |
|OTEL_SPAN_LINK_COUNT_LIMIT | | | | + | + | - | | | | | |
|OTEL_TRACES_SAMPLER | | | | + | + | + | | | | | |
|OTEL_TRACES_SAMPLER_ARG | | | | + | + | + | | | | | |

## Exporters

Expand Down
14 changes: 6 additions & 8 deletions specification/resource/semantic_conventions/process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,15 @@ In addition to these attributes, [`telemetry.sdk.language`](README.md#telemetry-

### Erlang Runtimes

TODO(<https://github.com/open-telemetry/opentelemetry-erlang/issues/96>): Confirm the contents here

- `process.runtime.name` - The name of the Erlang runtime being used. Usually will be BEAM.
- `process.runtime.version` - The ERTS (Erlang Runtime System) version. For BEAM this is found with `application:get_key(erts, vsn)`.
- `process.runtime.description` - The OTP version `erlang:system_info(otp_release)` and ERTS version combined.
- `process.runtime.name` - The name of the Erlang VM being used, i.e., `erlang:system_info(machine)`.
- `process.runtime.version` - The version of the runtime (ERTS - Erlang Runtime System), i.e., `erlang:system_info(version)`.
- `process.runtime.description` - string | An additional description about the runtime made by combining the OTP version, i.e., `erlang:system_info(otp_release)`, and ERTS version.

Example:

| Name | `process.runtime.name` | `process.runtime.version` | `process.runtime.description` |
| --- | --- | --- | --- |
| beam | BEAM | 11.0.3 | Erlang/OTP 24 erts-11.0.3 |
| `process.runtime.name` | `process.runtime.version` | `process.runtime.description` |
| --- | --- | --- |
| BEAM | 11.1 | Erlang/OTP 23 erts-11.1 |

### Go Runtimes

Expand Down