Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "Func" name, use "Asynchronous" and "Observable" #1645

Merged
merged 9 commits into from
Apr 27, 2021
Merged

Remove the "Func" name, use "Asynchronous" and "Observable" #1645

merged 9 commits into from
Apr 27, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Apr 26, 2021

Follow up #1617 (comment).

This has been discussed and concluded during the metrics API/SDK spec SIG meeting.

Changes

  • Used "Asynchronous Counter" as the name of the entry.
  • Added description to encourage implementations to use "ObservableCounter".
  • Clarified that these concepts have nothing to do with asynchronous pattern or observer pattern.
  • Changed other async instruments so we have consistency.

@reyang reyang requested review from a team as code owners April 26, 2021 17:04
@reyang reyang mentioned this pull request Apr 26, 2021
Merged
@reyang
Copy link
Member Author

reyang commented Apr 26, 2021 •
edited
Loading

@jonatan-ivanov @noahfalk @tarekgh @victlu FYI.

victlu
victlu approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@victlu victlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jkwatson
jkwatson approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

reyang and others added 4 commits April 26, 2021 11:06
@reyang @jkwatson
Update specification/metrics/new_api.md
d9ea135 
Co-authored-by: John Watson <jkwatson@gmail.com>
@reyang @jkwatson
Update specification/metrics/new_api.md
de72095 
Co-authored-by: John Watson <jkwatson@gmail.com>
@reyang @jkwatson
Update specification/metrics/new_api.md
044a768 
Co-authored-by: John Watson <jkwatson@gmail.com>
@reyang
rewrap
dc0d290
alolita
alolita reviewed Apr 27, 2021
View reviewed changes
Copy link
Member

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

noahfalk
noahfalk approved these changes Apr 27, 2021
View reviewed changes
Copy link

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SergeyKanzhelev SergeyKanzhelev merged commit 7ccd144 into open-telemetry:main Apr 27, 2021
@reyang reyang deleted the reyang/func-async branch April 27, 2021 20:44
@legendecas legendecas mentioned this pull request Dec 24, 2021
Merged
@jonatan-ivanov jonatan-ivanov mentioned this pull request Jun 15, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alolita alolita alolita left review comments

@weyert weyert weyert approved these changes

@jsuereth jsuereth jsuereth approved these changes

@ebullient ebullient ebullient approved these changes

@jkwatson jkwatson jkwatson approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@jonatan-ivanov jonatan-ivanov jonatan-ivanov approved these changes

@jmacd jmacd jmacd approved these changes

@cijothomas cijothomas cijothomas approved these changes

@noahfalk noahfalk noahfalk approved these changes

@tarekgh tarekgh tarekgh approved these changes

@victlu victlu victlu approved these changes

@aabmass aabmass Awaiting requested review from aabmass

Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
No open projects
Spec - Metrics API/SDK Experimental R...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet