Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write description for Gauge metric type in DataModel Specification #1661

Merged
merged 12 commits into from
May 11, 2021
Merged

Write description for Gauge metric type in DataModel Specification #1661

merged 12 commits into from
May 11, 2021

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Apr 29, 2021 •
edited
Loading

Adds a description of Gauge in the data model specification.

@jsuereth jsuereth marked this pull request as ready for review April 29, 2021 16:39
@jsuereth jsuereth requested review from a team as code owners April 29, 2021 16:39
punya
punya reviewed Apr 29, 2021
View reviewed changes
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
jsuereth and others added 2 commits April 29, 2021 12:55
@jsuereth @punya
Update specification/metrics/datamodel.md
952c913 
Co-authored-by: Punya Biswal <punya@google.com>
@jsuereth @punya
Update specification/metrics/datamodel.md
88737f3 
Co-authored-by: Punya Biswal <punya@google.com>
reyang
reyang approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kenfinnigan
kenfinnigan approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@kenfinnigan kenfinnigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsuereth

@arminru arminru added area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory labels May 6, 2021
@jsuereth jsuereth added this to Written Specification in Spec - Metrics Data Model and Protocol May 9, 2021
@jmacd jmacd merged commit 38d1430 into open-telemetry:main May 11, 2021
@jsuereth jsuereth deleted the wip-gauge branch February 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punya punya punya left review comments

@Oberon00 Oberon00 Oberon00 left review comments

@bogdandrutu bogdandrutu bogdandrutu left review comments

@kjordy kjordy kjordy left review comments

@kenfinnigan kenfinnigan kenfinnigan approved these changes

@ebullient ebullient ebullient approved these changes

@jmacd jmacd jmacd approved these changes

@reyang reyang reyang approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@jsuereth @punya @kenfinnigan @ebullient @Oberon00 @bogdandrutu @jmacd @kjordy @reyang @arminru