Refactor non-OTLP Format Mapping and Fix Dropped Attribute Count bug #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
feature/tigran/non-otlp-representation
branch
from
6b42a87
to
131bc6b
Compare
nrcventura
reviewed
Apr 29, 2021
nrcventura
reviewed
Apr 29, 2021
nrcventura
reviewed
Apr 29, 2021
yurishkuro
approved these changes
Apr 29, 2021
tigrannajaryan
force-pushed
the
feature/tigran/non-otlp-representation
branch
from
131bc6b
to
d3843b6
Compare
Fixes open-telemetry#1656 The documents that describe transformations to Jaeger and Zipkin contained duplicate information about how to record InstrumentationLibrary. They also contained incomplete and incorrect information about how to record dropped attribute count. This change extracts common transformation rules into a separate document (non-otlp.md) and references this document where appropriate. We also define otel.event.dropped_attributes_count as the only way to record dropped attribute count, regardless of the entity for which it is recorded. Previously in Jaeger format we specified that for Events we must use otel.event.dropped_attributes_count and did not specify at all what to use for Spans. I believe using the same uniform key for Spans and Events is correct. I consider this a specification bug and do not believe it should be treated as a breaking change. Also delete the Zipkin mapping for LocalChildSpanCount since there is no such OpenTelemetry field anymore.
tigrannajaryan
force-pushed
the
feature/tigran/non-otlp-representation
branch
from
d3843b6
to
5b71287
Compare
nrcventura
approved these changes
Apr 30, 2021
carlosalberto
approved these changes
May 3, 2021
|
cc @anuraaga |
yurishkuro
reviewed
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1656
The documents that describe transformations to Jaeger and Zipkin contained
duplicate information about how to record InstrumentationLibrary.
They also contained incomplete and incorrect information about how to record
dropped attribute count.
This change extracts common transformation rules into a separate document (non-otlp.md)
and references this document where appropriate.
We also define otel.event.dropped_attributes_count as the only way to record
dropped attribute count, regardless of the entity for which it is recorded.
Previously in Jaeger format we specified that for Events we must use
otel.event.dropped_attributes_count and did not specify at all what to use for Spans.
I believe using the same uniform key for Spans and Events is correct.
I consider this a specification bug and do not believe it should be treated as
a breaking change.
Also delete the Zipkin mapping for LocalChildSpanCount since there is no such
OpenTelemetry field anymore.