Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename api.md to old_api.md and update links (to point to new_api.md) #1674

Merged

Conversation

reyang
Copy link
Member

@reyang reyang commented May 6, 2021

Based on the comment from @arminru, I'm splitting the PR to two parts.

This is the 1st part. After this PR got merged, I will update #1672 which will be the 2nd part.

Previously we've decided to make progress on the metrics API spec by creating a separate new_api.md doc just to make PR review easier.

Now that the metrics API spec is getting in shape, we've discussed in the Apr. 29th Metrics API/SDK spec SIG meeting that we will rename it to api.md in early May.

I decided to keep the previous spec for now (by renaming it to old_api.md) so it won't confuse GitHub PR diff.

Changes

  • Renamed api.md to old_api.md.
  • Made necessary updates to the links.

Related oteps

@reyang reyang changed the title rename api.md to old_api.md and update links rename api.md to old_api.md and update links (to point to new_api.md) May 6, 2021
@reyang reyang added area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory labels May 6, 2021
@jmacd jmacd merged commit 12b5b27 into open-telemetry:main May 6, 2021
@reyang reyang deleted the reyang/flips-metrics-old-new-apis-part-1 branch October 4, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants