Add memcached to db.system semantic conventions #1689
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we already use `memcached` to represent the `db.system` Memcached in opentelemetry-python, I believe we should add to the specification recommendation https://github.com/open-telemetry/opentelemetry-python-contrib/blob/e606542981580971af1bbecbf07671c39f799665/instrumentation/opentelemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py#L160
Oberon00
approved these changes
May 12, 2021
arminru
added
area:semantic-conventions
arminru
approved these changes
May 12, 2021
carlosalberto
approved these changes
May 12, 2021
iNikem
approved these changes
May 13, 2021
arminru
reviewed
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we already use
memcachedto represent thedb.systemMemcached in opentelemetry-python, I believe we should add to the specification recommendation https://github.com/open-telemetry/opentelemetry-python-contrib/blob/e606542981580971af1bbecbf07671c39f799665/instrumentation/opentelemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py#L160Fixes #
Changes
Please provide a brief description of the changes here. Update the
CHANGELOG.mdfor non-trivial changes. IfCHANGELOG.mdis updated,also be sure to update
spec-compliance-matrix.mdif necessary.Related issues #
Related oteps #