Define how Schema URL works for Resources #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
feature/tigran/resource-schema
branch
from
6ec1495
to
353415d
Compare
reyang
approved these changes
May 13, 2021
iNikem
approved these changes
May 13, 2021
carlosalberto
approved these changes
May 13, 2021
jmacd
approved these changes
May 13, 2021
|
@bogdandrutu I'd love to get your eyes on this change before we merge ;) |
tigrannajaryan
force-pushed
the
feature/tigran/resource-schema
branch
2 times, most recently
from
3bb9e70
to
4168a42
Compare
|
I will merge this tomorrow if I don't hear any objections. |
tigrannajaryan
force-pushed
the
feature/tigran/resource-schema
branch
2 times, most recently
from
82884b8
to
5feebb3
Compare
This adds to the Resource SDK the concept of Schema URL proposed in OTEP 0152: https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md Related earlier PR that adds the Schema URL to the API: open-telemetry#1666
tigrannajaryan
force-pushed
the
feature/tigran/resource-schema
branch
from
5feebb3
to
fecb35a
Compare
|
Github actions are stuck, there is service degradation. Will merge once the actions pass. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the Resource SDK the concept of Schema URL proposed in OTEP 0152:
https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md
Related earlier PR that adds the Schema URL to the API:
#1666