adding DroppedLinksCount to non-otlp exporters section #1697
+45
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | Span.StartTime | Span.startTime | Span.start_time | See [Unit of time](#unit-of-time) | | ||
| | Span.EndTime | Span.duration | same | Calculated as EndTime - StartTime. See also [Unit of time](#unit-of-time) | | ||
| | Span.Attributes | Span.tags | same | See [Attributes](#attributes) for data types for the mapping. | | ||
| | OpenTelemetry | Jaeger Thrift | Jaeger Proto | Notes | |
There was a problem hiding this comment.
Are the style changes in both tables really needed? They seemed fine before, albeit with one space less ;)
There was a problem hiding this comment.
it's only my preference to keep things aligned in the table, i find it easier to read the markdown this way. I can change it back if you prefer.
carlosalberto
approved these changes
May 14, 2021
arminru
approved these changes
May 17, 2021
|
Thanks @arminru, changelog updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1696
Changes
Adding a similar section to events and attributes limit to the exporter specification.
Related issues #1656