Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the limit on the instrument unit #1762

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Clarify the limit on the instrument unit #1762

merged 3 commits into from
Jun 22, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Jun 15, 2021

Fixes #1746.

@reyang reyang requested review from a team as code owners June 15, 2021 16:19
@reyang reyang added area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory labels Jun 15, 2021
@carlosalberto
Copy link
Contributor

Can this be merged? It has more than enough approvals already.

@jmacd jmacd merged commit 00733a2 into open-telemetry:main Jun 22, 2021
@reyang reyang deleted the reyang/clarify-unit-limit branch June 24, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyert weyert weyert approved these changes

@jsuereth jsuereth jsuereth approved these changes

@jmacd jmacd jmacd approved these changes

@cijothomas cijothomas cijothomas approved these changes

@MrAlias MrAlias MrAlias approved these changes

Assignees

@jmacd jmacd

Labels
area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

confusing limit on unit size
7 participants
@reyang @carlosalberto @weyert @jsuereth @jmacd @cijothomas @MrAlias