Remove MetricProcessor from the SDK spec (for now) #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Jul 31, 2021
cijothomas
approved these changes
Jul 31, 2021
jsuereth
reviewed
Jul 31, 2021
| @@ -43,10 +42,10 @@ to create an | |||
| instance which is stored on the created `Meter`. | |||
|
|
|||
| Configuration (i.e., [MeasurementProcessors](#measurementprocessor), | |||
There was a problem hiding this comment.
Nit: I think we're not exposing MeasurementProcessor in the first version either, right? Just Views + MetricExporters.
There was a problem hiding this comment.
I think we need something that is generic (either we call it a processor or reader or something else), which allows exporters to be hooked up. I'd like to cover it in a separate PR.
Please refer to this comment from @bogdandrutu.
There was a problem hiding this comment.
Ping back from #617 (comment).
jsuereth
approved these changes
Jul 31, 2021
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
jmacd
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Discussed during the 7/29/2021 Metrics SIG. We're removing the
MetricProcessorfor now, most likely we will not expose such interface in the first release of the metrics SDK specification. If we need something similar, we will cover it in a separate PR (probably together with the exporters).@jsuereth FYI