Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify some cases for http.host and http.client_ip. #1890

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Clarify some cases for http.host and http.client_ip. #1890

merged 4 commits into from
Sep 7, 2021
+37 −7

Conversation

Oberon00
Copy link
Member

Fixes #1845.

Changes

@Oberon00 Oberon00 added area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory labels Aug 26, 2021
@Oberon00 Oberon00 requested review from a team as code owners August 26, 2021 16:48
@Oberon00 Oberon00 mentioned this pull request Aug 26, 2021
Closed
trask
trask approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 4, 2021
@iNikem
Copy link
Contributor

iNikem commented Sep 7, 2021

@open-telemetry/technical-committee Anything preventing this PR from merging?

@yurishkuro yurishkuro enabled auto-merge (squash) September 7, 2021 18:47
@yurishkuro yurishkuro merged commit 25b1451 into open-telemetry:main Sep 7, 2021
@Oberon00 Oberon00 deleted the http-clarify branch September 7, 2021 19:18
@trask trask mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@trask trask trask approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@iNikem iNikem iNikem approved these changes

@arminru arminru arminru approved these changes

Assignees

@yurishkuro yurishkuro

Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification on when to capture http.client_ip
7 participants
@Oberon00 @iNikem @anuraaga @trask @carlosalberto @arminru @yurishkuro