Discourage faas.trigger for client/outgoing spans. #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
area:semantic-conventions
Oberon00
commented
Sep 15, 2021
arminru
reviewed
Sep 15, 2021
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Oberon00
commented
Sep 15, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@anuraaga Maybe you can review this? |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
If nobody has an opinion on this, I would actually say that's a sign in favor of this PR. We can always put back recommendations to use it in some way, recommending to not use it for client-side spans seems like a safe thing to do for now if nobody knows what it is about. |
anuraaga
approved these changes
Oct 4, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
arminru
approved these changes
Oct 12, 2021
carlosalberto
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
faas.trigger does not really make sense for outgoing calls. Change wording to discourage its use for client spans..