Remove MeasurementProcessor from the Metrics SDK spec #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
approved these changes
Sep 17, 2021
reyang
added
area:sdk
jsuereth
reviewed
Sep 18, 2021
reyang
commented
Sep 18, 2021
jsuereth
approved these changes
Sep 20, 2021
bogdandrutu
approved these changes
Sep 21, 2021
|
How are we looking? Ready to merge? I see three reviews, so confirm this can be merged (prior to 1.7) @open-telemetry/specs-metrics-approvers |
|
@carlosalberto This can be merged, was giving it the business-day-wait-for-review required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed during the 08/12/2021 #186 Metrics SIG at 11am PT and we concluded that
MeasurementProcessorshould be removed.I didn't make the change at that time because we were focusing on getting the initial Experimental version done (which is achieved now).
Note: this CAN be part of the spec v1.7.0 release, although it does NOT HAVE TO be.