Update env variable values to match other env variables. #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
added
area:sdk
tigrannajaryan
approved these changes
Sep 24, 2021
|
Should this env var be also moved to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md where all the other env vars are? |
| @tigrannajaryan I see that prometheus env variables are there with experimental status. Yes I can move them. |
jkwatson
approved these changes
Sep 24, 2021
reyang
approved these changes
Sep 25, 2021
arminru
approved these changes
Sep 27, 2021
carlosalberto
approved these changes
Sep 27, 2021
jmacd
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exemplar environment variable configuration doesn't match lower-case convention in other SDK environment variable parameters.
Hat tip to @anuraaga for calling this out.
Note: This change is still ok because Metrics SDK specification is not stable, and this is not a new feature, just a change to an existing one. I believe there is no (released) implementation of this feature yet.