Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify metrics monotonicity #1995

Merged
merged 10 commits into from
Oct 13, 2021
Merged

Clarify metrics monotonicity #1995

merged 10 commits into from
Oct 13, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Oct 6, 2021 •
edited
Loading

Fixes #1593.

@reyang reyang requested review from a team as code owners October 6, 2021 07:06
@arminru arminru added the spec:metrics Related to the specification/metrics directory label Oct 7, 2021
@reyang reyang force-pushed the reyang/metrics-guideline-monotonicity branch from e14a97e to c8032cd Compare October 8, 2021 18:40
@reyang reyang changed the title Add supplementary doc about monotonicity Clarify metrics monotonicity Oct 8, 2021
@reyang reyang added area:api Cross language API specification issue duplicate This issue or pull request already exists labels Oct 9, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Oct 9, 2021
@jmacd jmacd merged commit 90b6df7 into open-telemetry:main Oct 13, 2021
Spec - Metrics API/SDK Feature Freeze automation moved this from In progress to Done Oct 13, 2021
@reyang reyang deleted the reyang/metrics-guideline-monotonicity branch October 18, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro left review comments

@jack-berg jack-berg jack-berg left review comments

@jsuereth jsuereth jsuereth approved these changes

@jmacd jmacd jmacd approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
area:api Cross language API specification issue duplicate This issue or pull request already exists spec:metrics Related to the specification/metrics directory
Projects
No open projects
Spec - Metrics API/SDK Feature Freeze
Done
Milestone
Metrics API/SDK Feature Freeze
Development

Successfully merging this pull request may close these issues.

Editorial change - call out that Counter is monotonic
7 participants
@reyang @jsuereth @yurishkuro @jmacd @jack-berg @bogdandrutu @arminru