Add device.manufacturer to semantic conventions for resources

[ladd]

Changes

• Proposed manufacturer field

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ ladd (08ab055)

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[ladd]

Could I get a review, please?

[arminru]

@ladd Please note that you will need to update the YAML definitions in this folder following the readme there:
https://github.com/open-telemetry/opentelemetry-specification/tree/main/semantic_conventions
By running the command documented there, the markdown table you edited manually will be generated automatically an make the build pass.

[ladd]

@ladd Please note that you will need to update the YAML definitions in this folder following the readme there: https://github.com/open-telemetry/opentelemetry-specification/tree/main/semantic_conventions By running the command documented there, the markdown table you edited manually will be generated automatically an make the build pass.

Thanks -- done!

[Oberon00]

Is this something we'd actually want to send? Since we already send device IDs, couldn't this be handled with a device database at the backend? Or do you think the practical advantages will be enough? Does one usually have an API that the instrumentation could call to get the manufacturer? Or would it have to have a DB?

[ladd]

Device ids are typically not mappable to manufacturer strings, unless you have a separate instrumentation mechanism to populate a DB. Device model strings can sometimes be mapped, but it normally requires licensing a proprietary database (like GSM Arena) I do think the practical advantages are there -- specific Android manufacturers often tweak the OS in compatibility breaking ways. The API exists for Android -- see my footnote in the PR. For iOS, you would normally just hardcode Apple.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[ladd]

Can I get a review / merge if the comments have been addressed?

[Oberon00]

Please add a CHANGELOG entry.

[ladd]

Can I get a review / merge if the comments have been addressed?

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.