Rename None aggregation to Drop #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwest
approved these changes
Nov 5, 2021
|
From one point of view I agree with this, WDYT of this change in relation to: #2102 |
reyang
approved these changes
Nov 7, 2021
jmacd
approved these changes
Nov 10, 2021
|
We've discussed this during the 11/11/2021 Metrics SIG Meeting, folks think I suggest that we move forward and merge the PR before Stable release. |
reyang
added this to In progress
in Spec - Metrics API/SDK Stable Release
via automation
MrAlias
approved these changes
Nov 12, 2021
jonatan-ivanov
approved these changes
Nov 12, 2021
carlosalberto
approved these changes
Nov 15, 2021
arminru
approved these changes
Nov 16, 2021
jsuereth
approved these changes
Nov 16, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop feels like a better name than "none". Want to check if others feel the same.
"The None Aggregation informs the SDK to ignore/drop all Instrument Measurements for this Aggregation."
Found some history: https://github.com/open-telemetry/opentelemetry-specification/pull/956/files