Rename extra dimensions to extra attributes #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Nov 24, 2021
reyang
added
spec:metrics
pirgeo
approved these changes
Nov 26, 2021
bogdandrutu
approved these changes
Nov 29, 2021
6 tasks
cijothomas
approved these changes
Nov 30, 2021
cijothomas
approved these changes
Nov 30, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jmacd
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there is a very clear definition of the word "dimension" in the spec. I did find one line that seems to indicate it's an alias of the word "attribute"
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/datamodel.md#timeseries-model
It seems like the spec would be more consistent using the word attribute here.