Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibit usage of retired names in semantic conventions #2191

Merged
merged 4 commits into from Dec 13, 2021
Merged

Prohibit usage of retired names in semantic conventions #2191

merged 4 commits into from Dec 13, 2021

Commits on Dec 13, 2021

  1. Prohibit usage of retired names in semantic conventions 

    This change adds a prohibition clause that requires that no old
metric or attribute name is used for a new attribute.

This is important to ensure reversibility of schema transformation
(converting from a new version to an old version of schema).

Without this restriction the following is possible:

Schema version 1. Attribute A exists.
Schema version 2. Attribute A is renamed to B. Appropriate schema file is created.
Schema version 3. Attribute A is introduced (a completely different new attribute).

Now attempting to go from Version 3 to version 1 is impossible since it requires
renaming B to A (for the change in version 2), but a different attribute A already exists.
    @tigrannajaryan
    tigrannajaryan committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    ccf2ba7 View commit details
    Browse the repository at this point in the history

  2. Fix based on comments

    @tigrannajaryan
    tigrannajaryan committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    19b33db View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @tigrannajaryan
    tigrannajaryan committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    66b37fa View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into add-limit-tosechamarenames

    @carlosalberto
    carlosalberto committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1106635 View commit details
    Browse the repository at this point in the history