Simplify Baggage handling in the OpenTracing Shim layer. #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baggage is NOT directly associated with an OpenTelemetry Span directly anymore, but with the OpenTracing Shim, which greatly simplifies its handling. This comes with the recommendation of NOT consuming the OpenTelemetry API and the OpenTracing Shim the codebase, as the Span's associated Baggage may be lost during in-process or inter-process Propagation.
|
Ping @yurishkuro |
yurishkuro
approved these changes
Dec 9, 2021
|
@yurishkuro Updated to discourage users from using the OT Shim along the OTel API only if baggage is used. |
yurishkuro
approved these changes
Dec 10, 2021
jmacd
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
I believe the OTel-Go bridge/opentracing goes extensively out of it's way to make the behavior being specified here work, also (a) I'm not 100% certain of this statement because the code is difficult to follow, and (b) if I'm proven correct then we ought to simplify the code based on this spec change. I'll file an issue if you agree @carlosalberto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baggage is NOT directly associated with an OpenTelemetry
Spandirectly anymore, but with the OpenTracing Shim layer, which greatly simplifies its handling (no more global dictionary or extra field in Spans).This comes with the recommendation of NOT consuming the OpenTelemetry API and the OpenTracing Shim the codebase, as the
Span's associatedBaggagemay be lost during in-process or inter-process propagation.I have a prototype for this in Java.
I'd added thread-safety requirements for
Baggageconsumption, even if it doesn't exist in the original OpenTracing Specification, as those calls are thread-safe anyway in most of (all?) OpenTracing compliant tracers.Fixes #2137