Clarify integer count instrument units #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
approved these changes
Dec 10, 2021
MrAlias
approved these changes
Dec 10, 2021
arminru
added
area:semantic-conventions
arminru
approved these changes
Dec 13, 2021
jsuereth
approved these changes
Dec 13, 2021
pirgeo
approved these changes
Dec 14, 2021
bogdandrutu
approved these changes
Dec 14, 2021
|
@arminru can you please rebase and merge this PR since you have all the right access? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the units that should be used for instruments that measure an integer count.
The spec mentioned that
Which, due to the use of "and" in the language, could be interpreted that units should be written as
1{packets},1{errors}and1{faults}. According to UCUM, however,{packets}semantically is equivalent to1{packets}.To prevent this interpretation, this PR clarifies that the leading
1should be omitted.