otlp configuration: rename INSECURE environment variables #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Jan 4, 2022
anuraaga
reviewed
Jan 4, 2022
tsloughter
force-pushed
the
insecure-env-var
branch
from
22e19c1
to
e9662f6
Compare
carlosalberto
approved these changes
Jan 7, 2022
codeboten
approved these changes
Jan 8, 2022
|
@tigrannajaryan @anuraaga Please review the latest wording - it looks great IMHO. |
anuraaga
approved these changes
Jan 8, 2022
This was referenced Jan 9, 2022
srikanthccv
approved these changes
Jan 9, 2022
iNikem
approved these changes
Jan 10, 2022
The old names `OTEL_EXPORTER_OTLP_SPAN_INSECURE` and `OTEL_EXPORTER_OTLP_METRIC_INSECURE` remain because they were part of a stable release of the specification.
tsloughter
force-pushed
the
insecure-env-var
branch
from
e9662f6
to
c17ac12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rename
OTEL_EXPORTER_OTLP_SPAN_INSECUREtoOTEL_EXPORTER_OTLP_TRACES_INSECUREandOTEL_EXPORTER_OTLP_METRIC_INSECUREtoOTEL_EXPORTER_OTLP_METRICS_INSECUREso they match the naming of all other OTLP environment variables.I did a search for
OTEL_EXPORTER_OTLP_SPAN_INSECUREon the repo expecting to find an issue already for this with the reason it hasn't been changed being it isn't backwards compatible. I'd say any implementation that already implements could just keep both?