Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database connection pool semantic conventions #2263

Closed
mateuszrzeszutek opened this issue Jan 12, 2022 · 0 comments · Fixed by #2273
Closed

Database connection pool semantic conventions #2263

mateuszrzeszutek opened this issue Jan 12, 2022 · 0 comments · Fixed by #2273
Assignees
Labels
area:semantic-conventions Related to semantic conventions semconv:database spec:metrics Related to the specification/metrics directory

Comments

@mateuszrzeszutek
Copy link
Member

What are you trying to achieve?

Before OTel metrics API went stable, in Splunk Java distro we have implemented several instrumentations that collect metrics from various JDBC connection pool libraries (using micrometer). Now that metrics API is stable, we want to upstream these - and for this to happen we need to have semantic conventions describing DB connection pool metrics.

Here's what we currently have in the Splunk distro: https://github.com/signalfx/splunk-otel-java/blob/main/docs/metrics.md#connection-pool-metrics
We've instrumented most (if not all) JDBC connection pool libraries available for Java users; the instruments described in the link above are what we came up with that fits all of those libs.

I'm planning to create a PR that ports these conventions over to the OTel spec; is there anything that I should take into consideration beforehand? E.g. any other utilities from other languages? (this is probably more of a question to the general community)

Additional context.

Splunk DB connection pool metrics: https://github.com/signalfx/splunk-otel-java/blob/main/docs/metrics.md#connection-pool-metrics

@mateuszrzeszutek mateuszrzeszutek added the spec:metrics Related to the specification/metrics directory label Jan 12, 2022
@Oberon00 Oberon00 added the area:semantic-conventions Related to semantic conventions label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:database spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants