Database connection pool metrics semantic conventions #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
added
area:semantic-conventions
MrAlias
reviewed
Jan 24, 2022
jack-berg
reviewed
Jan 28, 2022
MrAlias
approved these changes
Feb 1, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@open-telemetry/specs-approvers @open-telemetry/technical-committee can you take a look at this PR? Thanks! |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
pmm-sumo
reviewed
Feb 18, 2022
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
arminru
approved these changes
Mar 10, 2022
mateuszrzeszutek
force-pushed
the
database-connection-pool-spec
branch
from
3a5646a
to
19a46f8
Compare
|
@open-telemetry/specs-metrics-approvers please take a look :-) |
MrAlias
approved these changes
Mar 15, 2022
mateuszrzeszutek
force-pushed
the
database-connection-pool-spec
branch
from
19a46f8
to
5ef2a08
Compare
|
@open-telemetry/technical-committee can this PR be merged? |
yurishkuro
reviewed
Mar 17, 2022
jack-berg
reviewed
Mar 17, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
mateuszrzeszutek
force-pushed
the
database-connection-pool-spec
branch
from
5ef2a08
to
64e84a9
Compare
I think we don't have any yaml files for metrics specs yet. |
trask
reviewed
Mar 29, 2022
jack-berg
approved these changes
Mar 30, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
/unstale |
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
mateuszrzeszutek
force-pushed
the
database-connection-pool-spec
branch
from
b19c00b
to
90842b6
Compare
trask
approved these changes
Apr 17, 2022
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2263
Changes
Adds database connection pool metrics semantic conventions.
This PR is based on the DB connection pool metrics implemented in the Splunk Java instrumentation distro: