Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Prometheus Exporter default host to localhost #2282

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Change Prometheus Exporter default host to localhost #2282

merged 3 commits into from
Jan 25, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Jan 21, 2022

Fixes #2275.

@reyang reyang requested review from a team as code owners January 21, 2022 03:41
@reyang reyang mentioned this pull request Jan 21, 2022
Merged
2 tasks
tigrannajaryan
tigrannajaryan approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I commented about why I support this on the issue #2275 (comment)

@jmacd jmacd enabled auto-merge (squash) January 25, 2022 00:47
@jmacd jmacd merged commit 7b50438 into open-telemetry:main Jan 25, 2022
@reyang reyang deleted the reyang/fix-2275 branch January 25, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees

@carlosalberto carlosalberto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus Exporter default port is confusing and inconsistent
5 participants
@reyang @carlosalberto @tigrannajaryan @cijothomas @jmacd