Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metrics SDK spec to Mixed #2304

Merged
merged 21 commits into from Mar 22, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Jan 31, 2022

The Metrics SDK specification stabilization progress is tracked by https://github.com/orgs/open-telemetry/projects/9.

During the past 4 weeks, we haven't seen outstanding new issues during the weekly triage meeting, and all of the known blocking issues have been properly resolved.

Changes

  • Mark Metrics SDK specification to Mixed, with Exemplar as Feature-freeze while other parts as Stable.

@reyang reyang added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Jan 31, 2022
@reyang reyang added this to In progress in Spec - Metrics API/SDK Stable Release via automation Jan 31, 2022
@reyang reyang added this to the Metrics API/SDK Stable Release milestone Jan 31, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 9, 2022
@reyang
Copy link
Member Author

reyang commented Feb 11, 2022

We should revisit this PR once #2317 is merged.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 19, 2022
@alolita
Copy link
Member

alolita commented Feb 21, 2022

@reyang @jsuereth Can this PR be merged given #2317 is merged.

@jmacd
Copy link
Contributor

jmacd commented Mar 1, 2022

Note that #2072 appears to be still blocking this PR, unfortunately. In #2072 (comment) I have a proposal that would also let us close #2232, I think. Please give #2072 and #2232 your attention, especially @mateuszrzeszutek, @legendecas, @jack-berg, @jsuereth, @reyang thanks.

@jack-berg
Copy link
Member

I think that having some sort of resolution of #2314 is important for stabilization. My read is that there's consensus that delta backends actually want cumulative non-monotonic sums instead of delta non-monotonic sums for sync / async up down counter instruments. Stabilizing without some resolution would create trouble for these backends without benefiting anyone (as far as I can tell).

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 10, 2022
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approval after more recent PRs are merged.

@reyang
Copy link
Member Author

reyang commented Mar 22, 2022

This PR is blocked by a CI issue which is being addressed in #2426.

@mtwo
Copy link
Member

mtwo commented Mar 22, 2022

Following up from the specification call today: this is ready to merge

@reyang reyang merged commit 4588104 into open-telemetry:main Mar 22, 2022
Spec - Metrics API/SDK Stable Release automation moved this from In progress to Done Mar 22, 2022
@reyang reyang deleted the reyang/metrics-sdk-stable branch March 22, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet