Specify how to handle prometheus exemplar timestamp and attributes #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
exemplar_attributes
branch
from
63bc389
to
806d091
Compare
dashpole
force-pushed
the
exemplar_attributes
branch
from
806d091
to
517711c
Compare
MrAlias
approved these changes
Feb 23, 2022
Aneurysm9
approved these changes
Mar 2, 2022
jsuereth
approved these changes
Mar 4, 2022
dashpole
force-pushed
the
exemplar_attributes
branch
from
d80d5cc
to
e029db7
Compare
dashpole
force-pushed
the
exemplar_attributes
branch
from
e029db7
to
da76ab3
Compare
jmacd
approved these changes
Mar 4, 2022
|
I think this is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #2266 (review)
Changes
Specify how to convert prometheus exemplar timestamp and attributes to opentelemetry exemplars.
cc @anuraaga @bogdandrutu @jsuereth @jmacd