Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare Log Data Model Stable #2387

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented Feb 28, 2022

All issues that were identified to be required for this declaration
are closed: https://github.com/open-telemetry/opentelemetry-specification/issues?q=is%3Aopen+is%3Aissue+label%3Arelease%3Arequired-logdatamodel-ga

Anyone who believes there are reasons NOT to declare the data model
stable please speak now.

Note: non-breaking changes will be allowed even after declaring the data model stable.

This is the first call to everyone that we are planning to declare
log data model stable.

All issues that were identified to be required for this declaration
are closed: https://github.com/open-telemetry/opentelemetry-specification/issues?q=is%3Aopen+is%3Aissue+label%3Arelease%3Arequired-logdatamodel-ga

Anyone who believes there are reasons NOT to declare the data model
stable please speak now.

We need to keep this PR open for a while and circulate this intent
widely.
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 8, 2022
@tigrannajaryan tigrannajaryan changed the title [DO NOT MERGE] Declare Log Data Model Stable Declare Log Data Model Stable Mar 9, 2022
@tigrannajaryan tigrannajaryan marked this pull request as ready for review March 9, 2022 14:15
@tigrannajaryan tigrannajaryan requested review from a team as code owners March 9, 2022 14:15
@tigrannajaryan
Copy link
Member Author

@open-telemetry/specs-approvers @open-telemetry/specs-logs-approvers This was open for 9 days and I announced it several times in the meetings. We have zero objections so far. I believe we can move forward. Please review/approve.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@tigrannajaryan
Copy link
Member Author

@open-telemetry/technical-committee please review/approve.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a logging expert, but the change LGTM

@tigrannajaryan
Copy link
Member Author

This has been open for 3 weeks now. We have the necessary number of approvals to merge. Last chance to object.

@tigrannajaryan tigrannajaryan merged commit 057a1bc into open-telemetry:main Mar 22, 2022
@tigrannajaryan tigrannajaryan deleted the declare-logs-datamodel-stable branch March 22, 2022 16:50
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this pull request Mar 30, 2022
The log data model is now declared Stable: open-telemetry/opentelemetry-specification#2387

The OTLP proto in this repository now matches the log data model
in the specification.

This PR declares OTLP proto for logs Stable as well.
tigrannajaryan added a commit to open-telemetry/opentelemetry-proto that referenced this pull request May 10, 2022
The log data model is now declared Stable: open-telemetry/opentelemetry-specification#2387

The OTLP proto in this repository now matches the log data model
in the specification.

This PR declares OTLP proto for logs Stable as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants