Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that MetricReader has one-to-one mapping to MeterProvider #2406

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Clarify that MetricReader has one-to-one mapping to MeterProvider #2406

merged 5 commits into from
Mar 11, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Mar 7, 2022

Fixes #2072.

@reyang reyang requested review from a team as code owners March 7, 2022 06:43
@reyang reyang added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Mar 7, 2022
@reyang reyang added this to In progress in Spec - Metrics API/SDK Stable Release via automation Mar 7, 2022
@reyang reyang added this to the Metrics API/SDK Stable Release milestone Mar 7, 2022
@reyang reyang requested a review from legendecas March 7, 2022 06:45
legendecas
legendecas approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pirgeo
pirgeo approved these changes Mar 8, 2022
View reviewed changes
specification/metrics/sdk.md Outdated Show resolved Hide resolved
@reyang @pirgeo
Update specification/metrics/sdk.md
cf74b98 
Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com>
@reyang reyang added release:required-for-ga Must be resolved before GA release, or nice to have before GA release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs and removed release:required-for-ga Must be resolved before GA release, or nice to have before GA release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Mar 8, 2022
@reyang reyang merged commit 660826e into open-telemetry:main Mar 11, 2022
Spec - Metrics API/SDK Stable Release automation moved this from In progress to Done Mar 11, 2022
@reyang reyang deleted the reyang/metrics-sdk-reader-clarification branch March 11, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@jmacd jmacd jmacd approved these changes

@cijothomas cijothomas cijothomas approved these changes

@arminru arminru arminru approved these changes

@pirgeo pirgeo pirgeo approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
area:sdk Related to the SDK release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
No open projects
Spec - Metrics API/SDK Stable Release
Done
Milestone
Metrics API/SDK Stable Release
Development

Successfully merging this pull request may close these issues.

Clarification on MetricReader registered on MeterProvider
8 participants
@reyang @carlosalberto @jmacd @cijothomas @arminru @legendecas @pirgeo @tigrannajaryan