Add rpc.system value for Apache Dubbo #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
add-apache-dubbo-rpc-system-value
branch
from
64dab19
to
3e82906
Compare
arminru
added
area:semantic-conventions
arminru
approved these changes
Mar 29, 2022
jmacd
approved these changes
Mar 30, 2022
jack-berg
approved these changes
Mar 30, 2022
bogdandrutu
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds
rpc.systemvalue for Apache Dubbo.We have Java instrumentation for Apache Dubbo, and would like to "upstream" an
rpc.systemvalue for it.Btw, suggesting a value of
apache_dubboover justdubbo, because as @tydhot mentioned in open-telemetry/opentelemetry-java-instrumentation#5432: