Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic conventions for GraphQL #2456

Merged
merged 10 commits into from
Jun 15, 2022
Merged

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Mar 29, 2022

Changes

Add semantic conventions for GraphQL span name and attributes.

Related issues #1670

@laurit laurit requested review from a team as code owners March 29, 2022 20:09
@laurit laurit changed the title Add semantic conventions from GraphQL Add semantic conventions for GraphQL Mar 29, 2022
@reyang reyang added the area:semantic-conventions Related to semantic conventions label Mar 30, 2022
@svrnm
Copy link
Member

svrnm commented Apr 4, 2022

Thanks for creating this @laurit !

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does anyone have thoughts on dropping operation from the attribute names, e.g.

  • graphql.name
  • graphql.type
  • graphql.body

@svrnm
Copy link
Member

svrnm commented Apr 6, 2022

does anyone have thoughts on dropping operation from the attribute names, e.g.

I would keep it, there are other things in graphql that might have a name, type or body (not an expert on that, but by quickly reading the GraphQL spec I saw that there are also things like type definitions, fragments, response. Also, their spec could extend to contain other objects worth collecting)

While those other things are not yet specified here, one might do it in the future and naming it graphql.name|type|body would be limiting that effort.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 21, 2022
@trask
Copy link
Member

trask commented Apr 21, 2022

/unstale

@yurishkuro @svrnm @jamesmoessis any other thoughts on this?

@svrnm
Copy link
Member

svrnm commented Apr 21, 2022

@trask, thanks, I was under the assumption that this was closed already. I'm fine with it!

@github-actions github-actions bot removed the Stale label Apr 22, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 30, 2022
@github-actions github-actions bot added the Stale label Jun 1, 2022
@tigrannajaryan
Copy link
Member

@laurit please resolve the conversations and rebase from main to prepare for merging.

@open-telemetry/specs-approvers we have the minimum required number of approvals so unless I see objections I am going to merge this.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 10, 2022
@trask
Copy link
Member

trask commented Jun 15, 2022

@laurit looks like there's a merge conflict

@laurit
Copy link
Contributor Author

laurit commented Jun 15, 2022

@trask thanks, rebased.

@trask
Copy link
Member

trask commented Jun 15, 2022

@open-telemetry/technical-committee I think this is ready to be merged, thx!

@tigrannajaryan tigrannajaryan merged commit 5fb819c into open-telemetry:main Jun 15, 2022
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
Add semantic conventions for GraphQL span name and attributes.

Related issues open-telemetry#1670
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
Add semantic conventions for GraphQL span name and attributes.

Related issues open-telemetry#1670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet