Update JVM metrics with JMX Gatherer values. #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Apr 8, 2022
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
|
@bogdandrutu @trask Please review (check is failing but that's not related to these changes). |
1 similar comment
|
@bogdandrutu @trask Please review (check is failing but that's not related to these changes). |
reyang
added
area:semantic-conventions
jmacd
approved these changes
Apr 18, 2022
jack-berg
reviewed
Apr 19, 2022
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
jack-berg
reviewed
Apr 19, 2022
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
jack-berg
approved these changes
Apr 19, 2022
trask
approved these changes
Apr 20, 2022
jmacd
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pair of metrics from the JMX Gatherer, renamed accordingly to comply with the existing runtime metrics:
process.runtime.jvm.threads.count(renamed fromjvm.threads.count), UpDownCounterprocess.runtime.jvm.classes.loaded(renamed fromjvm.classes.loaded), UpDownCounterprocess.runtime.jvm.classes.unloaded(new), UpDownCounter(Left out the GC metrics as those probably belong to its own discussion)