Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure FaaS conventions. #2502

Merged
merged 21 commits into from
May 13, 2022
Merged

Azure FaaS conventions. #2502

merged 21 commits into from
May 13, 2022

Conversation

Oberon00
Copy link
Member

Changes

  • Add details for FaaS conventions for Azure Functions
  • Allow FaaS/Cloud resources as span attributes on incoming FaaS spans.

@Oberon00 Oberon00 added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory labels Apr 19, 2022
@Oberon00 Oberon00 marked this pull request as ready for review April 25, 2022 11:57
@Oberon00 Oberon00 requested review from a team as code owners April 25, 2022 11:57
joaopgrassi
joaopgrassi reviewed Apr 26, 2022
View reviewed changes
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions on possible ways to structure the text a bit differently. I feel the way it is now it's not so obvious that for some cases the attributes has to be added on the span. Take it with a 🤌 of salt.

semantic_conventions/resource/faas.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/faas.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/faas.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/faas.yaml Outdated Show resolved Hide resolved
specification/trace/semantic_conventions/faas.md Show resolved Hide resolved
specification/trace/semantic_conventions/faas.md Show resolved Hide resolved
specification/trace/semantic_conventions/faas.md Outdated Show resolved Hide resolved
specification/trace/semantic_conventions/faas.md Outdated Show resolved Hide resolved
specification/trace/semantic_conventions/faas.md Outdated Show resolved Hide resolved
specification/trace/semantic_conventions/faas.md Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu assigned reyang and unassigned bogdandrutu Apr 26, 2022
@bogdandrutu
Copy link
Member

/cc @reyang I added you here since you have better experience with this product than I have :)

joaopgrassi
joaopgrassi reviewed May 6, 2022
View reviewed changes
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things

semantic_conventions/resource/faas.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/faas.yaml Show resolved Hide resolved
semantic_conventions/resource/faas.yaml Outdated Show resolved Hide resolved
specification/trace/semantic_conventions/faas.md Show resolved Hide resolved
Oberon00 and others added 3 commits May 6, 2022 13:17
@Oberon00 @joaopgrassi
Update semantic_conventions/resource/faas.yaml
21b845f 
Co-authored-by: Joao Grassi <joao@joaograssi.com>
@Oberon00 @joaopgrassi
Update semantic_conventions/resource/faas.yaml
344edda 
Co-authored-by: Joao Grassi <joao@joaograssi.com>
@Oberon00
make table-generation
e61a2dc
joaopgrassi
joaopgrassi approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so familiar with the vendor's technicalities, but all-in-all I think this looks good and makes things clearer.

@carlosalberto
Copy link
Contributor

@open-telemetry/specs-approvers Please review.

@Oberon00 Oberon00 requested a review from reyang May 9, 2022 14:02
@reyang
Copy link
Member

reyang commented May 13, 2022

What happened? 🤣

image

@reyang reyang closed this May 13, 2022
@reyang reyang reopened this May 13, 2022
@reyang reyang merged commit aa6e3e5 into open-telemetry:main May 13, 2022
@Oberon00 Oberon00 deleted the feature/faas-azure branch May 16, 2022 07:31
@Oberon00 Oberon00 mentioned this pull request Jul 28, 2022
Open
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
@Oberon00 @beeme1mr
Azure FaaS conventions. (open-telemetry#2502)
ec42aed
@Flarna Flarna mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@reyang reyang reyang approved these changes

Assignees

@reyang reyang

Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Oberon00 @bogdandrutu @carlosalberto @reyang @joaopgrassi