Map SunOS to solaris for os.type resource attribute
#2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Oberon00
approved these changes
Apr 25, 2022
arminru
approved these changes
Apr 25, 2022
arminru
added
area:semantic-conventions
tigrannajaryan
approved these changes
Apr 26, 2022
bogdandrutu
approved these changes
Apr 26, 2022
reyang
approved these changes
Apr 27, 2022
reyang
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Both Solaris and SunOS are unfamiliar for me, but some runtimes(Node.js) might have a value
sunosor similar for Solaris platform which might confuse implementors whether this falls under a well-known value or not. I suggest adding "SunOS" next to "Oracle Solaris" to make that clear.Trivial change - didn't update the changelog.