Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C++ metrics values in compliance matrix. #2546

Merged
merged 3 commits into from May 19, 2022
Merged

Update C++ metrics values in compliance matrix. #2546

merged 3 commits into from May 19, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented May 17, 2022

cc @open-telemetry/cpp-contrib-maintainers

@lalitb lalitb requested review from a team as code owners May 17, 2022 21:11
arminru
arminru approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@open-telemetry/cpp-maintainers please double-check.

@tigrannajaryan
Copy link
Member

Did we change something in the proto repo for this to happen?

FILE: ./specification/metrics/datamodel.md
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L198
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L192
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L211

  116 links checked.

  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L198 → Status: 404
  ERROR: 3 dead links found!
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L192 → Status: 404
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L211 → Status: 404

@lalitb
Copy link
Member Author

lalitb commented May 18, 2022

Did we change something in the proto repo for this to happen?

FILE: ./specification/metrics/datamodel.md
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L198
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L192
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L211

  116 links checked.

  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L198 → Status: 404
  ERROR: 3 dead links found!
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L192 → Status: 404
  [✖] https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.x/opentelemetry/proto/metrics/v1/metrics.proto#L211 → Status: 404

Seems #2552 will fix this. We can merge that PR before this.

@reyang reyang merged commit 639a06c into open-telemetry:main May 19, 2022
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
@lalitb @beeme1mr
Update C++ metrics values in compliance matrix. (open-telemetry#2546)
50c10aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@arminru arminru arminru approved these changes

@reyang reyang reyang approved these changes

@esigo esigo esigo approved these changes

Assignees

@carlosalberto carlosalberto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lalitb @tigrannajaryan @ThomsonTan @arminru @reyang @esigo @carlosalberto