Clarify when "count" is used instead of pluralization #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
approved these changes
Jun 9, 2022
The existing pluralization rule does not explain why we have metrics like `system.processes.count`. This adds a paragraph to explain when `count` is used instead of pluralization. Resolves open-telemetry#2553
tigrannajaryan
force-pushed
the
feature/tigran/clarify-metric-count-naming
branch
from
f6e033d
to
b2d7997
Compare
|
@vincentff7 please review. |
jack-berg
approved these changes
Jun 9, 2022
reyang
approved these changes
Jun 10, 2022
carlosalberto
approved these changes
Jun 13, 2022
|
cc @jmacd |
arminru
added
area:semantic-conventions
beeme1mr
pushed a commit
to beeme1mr/opentelemetry-specification
that referenced
this pull request
Aug 31, 2022
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing pluralization rule does not explain why we have
metrics like
system.processes.count.This adds a paragraph to explain when
countis used insteadof pluralization.
Resolves #2553