[OM/OTLP] Use _created for StartTimeUnixNano and vice-versa #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
arminru
added
spec:metrics
jmacd
approved these changes
Jul 8, 2022
jsuereth
approved these changes
Jul 12, 2022
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
start-time-prom-otlp
branch
from
1bfef00
to
21cbec7
Compare
|
Hey, yep, I will create the follow up issues in collector-contrib once this is merged. I've rebased it to remove the conflict. |
reyang
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
OpenMetrics has the
_createdmetric which is very similar toStartTimeUnixNano, convert one into the other.