Make periodic exporting MetricReader env vars stable #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
reyang
reviewed
Jul 11, 2022
|
PTAL @open-telemetry/java-instrumentation-maintainers @open-telemetry/python-maintainers @open-telemetry/php-approvers @open-telemetry/wg-prometheus |
reyang
requested changes
Jul 13, 2022
There was a problem hiding this comment.
The OTEL_METRICS_EXEMPLAR_FILTER is still in very early stage and should remain as Experimental, consider marking the "Metrics SDK Configuration" status as Mixed, and make the "Periodic exporting MetricReader" section Stable.
In addition, consider making an update in https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md#environment-variables. Doesn't have to be in this PR though.
pellared
changed the title
pellared
changed the title
reyang
approved these changes
Jul 14, 2022
Kielek
approved these changes
Jul 14, 2022
cijothomas
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Mark
OTEL_METRIC_EXPORT_INTERVAL,OTEL_METRIC_EXPORT_TIMEOUTenvironment variables as stable.Why
I think this change is representing the current state as all of these env vars are already implemented in OTel PHP, OTel Python, and partially by OTel Java.
See:
OTEL_METRIC_EXPORT_INTERVALusageOTEL_METRIC_EXPORT_TIMEOUTusageCreated because of: open-telemetry/opentelemetry-dotnet#3424