add definition for state attribute of system.network.connections #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing wikipedia link with set values for the state. I would add that the states listed here only apply to TCP protocol, which reinforces my thinking that the system.network.connections metric should be split by protocol. Asking reviewers to consider this. If folks agree, I will open a follow up PR to mark `system.network.connections` as deprecated in favour of `system.network.tcp.connections` and `system.network.udp.connections`. Fixes open-telemetry#2623
jmacd
approved these changes
Jul 14, 2022
reyang
approved these changes
Jul 14, 2022
arminru
added
area:semantic-conventions
arminru
approved these changes
Jul 18, 2022
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
The semantics introduced by this PR allowing to distinguish TCP and UDP by the presence or absence of |
codeboten
pushed a commit
to codeboten/opentelemetry-specification
that referenced
this pull request
Jul 18, 2022
As a follow up to open-telemetry#2663, since UDP has no state attribute, I propose UDP and TCP connection metrics should be split into protocol specific metric for each supported protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2623
Changes
Replacing wikipedia link with set values for the state. I would add that the states listed here only apply to TCP protocol, which reinforces my thinking that the system.network.connections metric should be split by protocol. Asking reviewers to consider this.
If folks agree, I will open a follow up PR to mark
system.network.connectionsas deprecated in favour of:system.network.tcp.connectionssystem.network.udp.connections