Add optional Zero Threshold for Exponential Histograms to the metrics data model #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
force-pushed
the
add-zero-threshold
branch
from
dbb4cff
to
f436101
Compare
beorn7
suggested changes
Jul 15, 2022
This is a field that exists and is used in Prometheus Exponential Histograms and it would be nice to include it in OTel Exponential Histograms as well. You can see the reference implementation here: https://github.com/prometheus/prometheus/blob/5937b4f5d4f658758f4aa6b9ab803f022e6e5497/model/histogram/float_histogram.go#L186-L197 https://github.com/prometheus/prometheus/blob/5937b4f5d4f658758f4aa6b9ab803f022e6e5497/model/histogram/float_histogram.go#L770-L790 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
add-zero-threshold
branch
from
f436101
to
e5565b7
Compare
jsuereth
approved these changes
Jul 19, 2022
jack-berg
reviewed
Jul 19, 2022
reyang
approved these changes
Jul 26, 2022
jmacd
approved these changes
Jul 27, 2022
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
jmacd
changed the title
|
@gouthamve I changed the PR title to limit its scope to match what's currently reviewed. I think after this merges, we're free to add it in the protocol for OTLP v0.20. Separately, we'll update ./sdk.md to say that expo-histos will accept an option and will have a default behavior w.r.t. this new thing--this we can debate later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #2611 and the Prometheus WG call from June 22, 2022.
Changes
This discusses the
zero_thresholdfield that exists and is used in Prometheus Exponential Histograms and it would be nice to include it in OTel Exponential Histograms as well.You can see the reference implementation here:
https://github.com/prometheus/prometheus/blob/5937b4f5d4f658758f4aa6b9ab803f022e6e5497/model/histogram/float_histogram.go#L186-L197
https://github.com/prometheus/prometheus/blob/5937b4f5d4f658758f4aa6b9ab803f022e6e5497/model/histogram/float_histogram.go#L770-L790
Prometheus also uses it (increases
zero_threshold) to limit the number of buckets: https://github.com/prometheus/client_golang/blob/5a321c7b05264e54d2dbc86f12d9b80d4e7a492b/prometheus/histogram.go#L773-L808DDSketch from Datadog uses something similar to limit the number of buckets (they expand the lowest bucket, not zero bucket but same principle).
Related issues #2611