Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional process metrics to the metrics semantic conventions #2706

Merged
merged 5 commits into from
Sep 21, 2022

Conversation

evan-bradley
Copy link
Contributor

@evan-bradley evan-bradley commented Aug 2, 2022

Changes

Fixes #2708

Add the following process metrics to the semantic conventions:

  • process.context_switches
  • process.open_file_descriptors

Related issues open-telemetry/opentelemetry-collector-contrib#12482

This will need to be rebased on #2705 before it can be merged.

@evan-bradley evan-bradley requested review from a team as code owners August 2, 2022 17:44
@evan-bradley evan-bradley force-pushed the add-process-metrics branch 3 times, most recently from 9a111c7 to 09c3027 Compare August 2, 2022 18:53
@arminru arminru added enhancement New feature or request area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory labels Aug 4, 2022
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated with the PR change, but I noticed the page is using "Labels". Should we change everywhere to use "Attributes" instead?

CHANGELOG.md Outdated Show resolved Hide resolved
@evan-bradley evan-bradley force-pushed the add-process-metrics branch 2 times, most recently from a9cc1f7 to 8279de9 Compare August 8, 2022 16:07
Copy link
Contributor

@carlosalberto carlosalberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this till #2726 is resolved (we will merge it with the proper changes after that, etc).

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 26, 2022
@arminru arminru removed the Stale label Aug 26, 2022
@github-actions
Copy link

github-actions bot commented Sep 3, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 3, 2022
@evan-bradley
Copy link
Contributor Author

I've changed this to follow the direction taken in #2748. I'd like to continue with using a label for now, and later change the approach if necessary after #2726 is resolved.

@github-actions github-actions bot removed the Stale label Sep 9, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 16, 2022
@andrzej-stencel
Copy link
Member

@carlosalberto I believe this is unblocked now, is that right?

@evan-bradley is there anything more needed here? (other than refreshing the PR)

@github-actions github-actions bot removed the Stale label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions enhancement New feature or request spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional process metrics to the metrics semantic conventions
10 participants