Add additional process metrics to the metrics semantic conventions #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
force-pushed
the
add-process-metrics
branch
3 times, most recently
from
9a111c7
to
09c3027
Compare
arminru
added
enhancement
This was referenced Aug 4, 2022
bogdandrutu
reviewed
Aug 4, 2022
evan-bradley
force-pushed
the
add-process-metrics
branch
from
09c3027
to
0c6f191
Compare
arminru
reviewed
Aug 5, 2022
joaopgrassi
reviewed
Aug 5, 2022
evan-bradley
force-pushed
the
add-process-metrics
branch
from
0c6f191
to
d5d95f4
Compare
joaopgrassi
reviewed
Aug 8, 2022
evan-bradley
force-pushed
the
add-process-metrics
branch
2 times, most recently
from
a9cc1f7
to
8279de9
Compare
joaopgrassi
approved these changes
Aug 8, 2022
arminru
approved these changes
Aug 8, 2022
reyang
approved these changes
Aug 8, 2022
carlosalberto
approved these changes
Aug 9, 2022
bogdandrutu
reviewed
Aug 9, 2022
jmacd
approved these changes
Aug 9, 2022
carlosalberto
requested changes
Aug 18, 2022
There was a problem hiding this comment.
Blocking this till #2726 is resolved (we will merge it with the proper changes after that, etc).
6 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Add the following: - `process.context_switches` - `process.open_file_descriptors`
evan-bradley
force-pushed
the
add-process-metrics
branch
from
0e3b785
to
9a87564
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@carlosalberto I believe this is unblocked now, is that right? @evan-bradley is there anything more needed here? (other than refreshing the PR) |
carlosalberto
approved these changes
Sep 20, 2022
cijothomas
approved these changes
Sep 21, 2022
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2708
Add the following process metrics to the semantic conventions:
process.context_switchesprocess.open_file_descriptorsRelated issues open-telemetry/opentelemetry-collector-contrib#12482
This will need to be rebased on #2705 before it can be merged.