Prohibit usage of enum value name strings in OTLP/JSON #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
approved these changes
Aug 30, 2022
Resolves open-telemetry/opentelemetry-proto#424 This change disallows using enum value names as strings in OTLP/JSON and requires to use enum integer values only.
tigrannajaryan
force-pushed
the
feature/tigran/enums-otlp-json
branch
from
6550c72
to
10b025b
Compare
jmacd
approved these changes
Aug 30, 2022
scheler
reviewed
Aug 30, 2022
bogdandrutu
approved these changes
Sep 1, 2022
carlosalberto
added
the
spec:protocol
reyang
approved these changes
Sep 9, 2022
pichlermarc
approved these changes
Sep 12, 2022
jack-berg
approved these changes
Sep 13, 2022
9 tasks
This was referenced Oct 7, 2022
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
Oct 17, 2022
- The severityNumber field is an enum and must use a numeric value according this: open-telemetry#2758 - Link to a more appropriate section of otlp.md doc.
This was referenced Oct 18, 2022
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
Nov 2, 2022
- The severityNumber field is an enum and must use a numeric value according this: open-telemetry#2758 - Link to a more appropriate section of otlp.md doc.
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-specification
that referenced
this pull request
Nov 2, 2022
- The severityNumber field is an enum and must use a numeric value according this: open-telemetry#2758 - Link to a more appropriate section of otlp.md doc.
tigrannajaryan
added a commit
that referenced
this pull request
Nov 3, 2022
- The severityNumber field is an enum and must use a numeric value according this: #2758 - Link to a more appropriate section of otlp.md doc. - Remove deprecatedCode - Use numeric value for status code
lmolkova
pushed a commit
to lmolkova/opentelemetry-specification
that referenced
this pull request
Nov 3, 2022
…metry#2886) - The severityNumber field is an enum and must use a numeric value according this: open-telemetry#2758 - Link to a more appropriate section of otlp.md doc. - Remove deprecatedCode - Use numeric value for status code
ChengJinbao
added a commit
to ChengJinbao/opentelemetry-specification
that referenced
this pull request
Nov 16, 2022
- The severityNumber field is an enum and must use a numeric value according this: open-telemetry/opentelemetry-specification#2758 - Link to a more appropriate section of otlp.md doc. - Remove deprecatedCode - Use numeric value for status code
3 tasks
joaopgrassi
pushed a commit
to dynatrace-oss-contrib/semantic-conventions
that referenced
this pull request
Mar 21, 2024
- The severityNumber field is an enum and must use a numeric value according this: open-telemetry/opentelemetry-specification#2758 - Link to a more appropriate section of otlp.md doc. - Remove deprecatedCode - Use numeric value for status code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves open-telemetry/opentelemetry-proto#424
This change disallows using enum value names as strings
in OTLP/JSON and requires to use enum integer values only.
This change is stacked on top of #2756
which needs to be merged first.