Add mobile and language semconv for browser resource #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheler
changed the title
arminru
added
area:semantic-conventions
arminru
reviewed
Aug 30, 2022
martinkuba
reviewed
Aug 30, 2022
|
@arminru @martinkuba anything else you would like in this PR for your approval? |
arminru
approved these changes
Sep 6, 2022
reyang
approved these changes
Sep 6, 2022
|
Should we ask people from the instrumentation SIG to bless this PR? |
The instrumentation SIG itself needs to be blessed first, and currently it's pending #2753. |
martinkuba
approved these changes
Sep 6, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@carlosalberto does this PR have required approvals for merging or more are needed? |
MSNev
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding semantic convention for a couple of browser attributes - mobile and language.
The term
mobilecan be confusing but it is taken straight from the UA Client Hints API `navigator.userAgentData.mobile).Related issues #
#2353