Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTEL_EXPORTER_OTLP_LOGS_* environment variables #2782

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Sep 9, 2022

Fixes #2781

Question: OTEL_EXPORTER_OTLP_LOGS_* or OTEL_EXPORTER_OTLP_LOGRECORDS_*?

@reyang
Copy link
Member

reyang commented Sep 9, 2022

I would vote for _LOGS_ instead of _LOGRECORDS_ considering folks who configure these environment variables are not necessarily developers who need to handle the data type / programming model. (e.g. we also use _TRACES_ instead of _SPANS_)

@reyang
Copy link
Member

reyang commented Sep 9, 2022

Couple things to consider:

  1. Do we want to mark these as Experimental for now, and turn it to Stable later? (I think it's okay to mark these Stable)
  2. Changelog?
  3. Update the feature matrix?

@reyang reyang added spec:logs Related to the specification/logs directory area:sdk Related to the SDK area:configuration Related to configuring the SDK labels Sep 9, 2022
@alanwest
Copy link
Member Author

alanwest commented Sep 9, 2022

  1. Do we want to mark these as Experimental for now, and turn it to Stable later? (I think it's okay to mark these Stable)

My thought was that stable should be fine as well.

  1. Changelog?

Updated.

  1. Update the feature matrix?

The feature matrix does not currently callout the signal-specific OTLP exporter env vars

|OTEL_EXPORTER_OTLP_* | + | + | | + | + | + | - | + | + | + | - |
I guess we could add them though?

@reyang reyang merged commit ab70eb9 into open-telemetry:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK area:sdk Related to the SDK spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OTEL_EXPORTER_OTLP_LOGS_* environment variable config
5 participants