Clarify that unknown fields must be ignored when receiving OTLP/JSON #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
feature/tigran/clairfy-json-unknown-fields
branch
2 times, most recently
from
3700398
to
62f2367
Compare
tigrannajaryan
changed the title
reyang
approved these changes
Sep 22, 2022
|
@open-telemetry/specs-approvers please review. |
bogdandrutu
approved these changes
Sep 23, 2022
bogdandrutu
approved these changes
Sep 23, 2022
yurishkuro
reviewed
Sep 25, 2022
carlosalberto
approved these changes
Sep 26, 2022
Resolves open-telemetry/opentelemetry-proto#425 The proposed behavior is necessary for interoperability of senders and receivers when OTLP protocol evolves in an allowed way: by adding new fields to existing messages.
tigrannajaryan
force-pushed
the
feature/tigran/clairfy-json-unknown-fields
branch
from
f13982d
to
c23843b
Compare
yurishkuro
approved these changes
Sep 26, 2022
|
Let's keep this open for a bit more since I deleted a sentence (although it doesn't change the meaning in any way). |
bogdandrutu
reviewed
Sep 27, 2022
pichlermarc
approved these changes
Sep 27, 2022
MrAlias
approved these changes
Sep 27, 2022
bogdandrutu
approved these changes
Sep 27, 2022
tigrannajaryan
deleted the
feature/tigran/clairfy-json-unknown-fields
branch
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves open-telemetry/opentelemetry-proto#425
The proposed behavior is necessary for interoperability of senders and receivers when OTLP protocol evolves in an allowed way: by adding new fields to existing messages.