Allow to configure min/max recording in the exponential histogram aggregation #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regation. Since min max are optional in the proto definition. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
recordminmax
branch
from
8db49ed
to
216d1a4
Compare
carlosalberto
approved these changes
Oct 27, 2022
MrAlias
approved these changes
Oct 27, 2022
reyang
approved these changes
Oct 27, 2022
cijothomas
approved these changes
Oct 27, 2022
jmacd
approved these changes
Oct 31, 2022
lmolkova
pushed a commit
to lmolkova/opentelemetry-specification
that referenced
this pull request
Nov 3, 2022
…regation. (open-telemetry#2904) Since min max are optional in the proto definition. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Reiley Yang <reyang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since min max are optional in the proto definition, see https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L560