Move Prometheus/OpenMetrics compatibility to its own file #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
move_prom_compat
branch
from
fd46e42
to
ae9e7b5
Compare
reyang
reviewed
Nov 15, 2022
reyang
approved these changes
Nov 15, 2022
dashpole
force-pushed
the
move_prom_compat
branch
2 times, most recently
from
0dc2a66
to
a9a6d21
Compare
jsuereth
approved these changes
Nov 16, 2022
jack-berg
approved these changes
Nov 16, 2022
dashpole
force-pushed
the
move_prom_compat
branch
from
91373b0
to
a00b4b9
Compare
dashpole
force-pushed
the
move_prom_compat
branch
from
a00b4b9
to
353ca8e
Compare
|
I removed openmetrics-guidelines.md from the semantic_conventions folder as well. It duplicated information already present in the compatibility docs, and probably doesn't belong in the semantic conventions. |
jmacd
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2890 (comment)
Changes
Move Prometheus compatibility spec from specification/metrics/data-model.md to specification/compatibility/openmetrics.md. No other changes
cc @jack-berg @Aneurysm9 @reyang @jsuereth @jmacd