New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify specification compliance #2968
Closed
+19
−7
Closed
Changes from 3 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
bd7c465
clarify specification compliance
reyang 6e41c00
update changelog
reyang b74377c
wording
reyang 27c7e03
Merge branch 'main' into reyang/clarify-compliance
reyang 5073355
taking Armin's suggestion
reyang 09fe2f7
Merge branch 'main' into reyang/clarify-compliance
reyang 3817dc8
Merge branch 'main' into reyang/clarify-compliance
reyang b5db125
address Carlos' comment
reyang ac77cc4
Update specification/README.md
reyang 708703f
Merge branch 'main' into reyang/clarify-compliance
arminru 342f2eb
Merge branch 'main' into reyang/clarify-compliance
reyang 66174fb
be conservative about the API spec, be flexible about the SDK spec
reyang 2e976f6
Merge branch 'main' into reyang/clarify-compliance
reyang e01ac6d
Merge branch 'main' into reyang/clarify-compliance
arminru 0c129e0
Merge branch 'main' into reyang/clarify-compliance
reyang d578c9e
fix changelog
reyang 6ee51a4
Update specification/README.md
reyang eacf845
Merge branch 'main' into reyang/clarify-compliance
reyang eb3443f
Merge branch 'main' into reyang/clarify-compliance
reyang 8c42e39
Merge branch 'main' into reyang/clarify-compliance
arminru 977e547
Merge branch 'main' into reyang/clarify-compliance
arminru f0d0af7
Merge branch 'main' into reyang/clarify-compliance
arminru f36a8f9
Merge branch 'main' into reyang/clarify-compliance
arminru e5d5d08
Merge branch 'main' into reyang/clarify-compliance
reyang 5567970
Merge branch 'main' into reyang/clarify-compliance
reyang File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend that this section only apply to the instrumentation API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By this you mean "the API" vs "the SDK", yes? "Instrumentation API" is a new term to me, and I want to make sure I understand what you mean by it. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think he's referring to "instrumentation API" to mean the API yes. All of the calls that instrumentations make into the API to actually create spans/metrics/logs. I think this does not include the helpers some languages have created for creating instrumentation infrastructure like patching code.