OpenTracing Shim: Add Tracer.Close() operation. #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Dec 19, 2022
yurishkuro
reviewed
Dec 19, 2022
yurishkuro
approved these changes
Dec 21, 2022
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
tylerbenson
approved these changes
Dec 21, 2022
ocelotl
approved these changes
Dec 21, 2022
MrAlias
reviewed
Dec 21, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
yurishkuro
approved these changes
Dec 22, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jmacd
reviewed
Jan 4, 2023
This was referenced Jan 4, 2023
reyang
approved these changes
Jan 10, 2023
MrAlias
approved these changes
Jan 12, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
jmacd
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon cleaning up the existing OT Shim for Java, realized we missed adding
Tracer.Close().I'd argue we are fine adding this, as:
In case #2944 is approved/solved, we could simply implement flushing by then.
cc @yurishkuro